Is this sentence subjunctive or indicative?
She was the best girlfriend i have ever had.
is it subjunctive or indicative?
and is this a correct way to say it "Ella era la mejor novia que yo jamas he tenido"
2 Answers
She was the best girlfriend [that] i have ever had.

Indicative here as the girl exists and is known to the speaker.
Ella fue la mejor novia que jamas tuve (sounds better imo than he tenido, but both work) The syntax in the translation above is very confusing.
And there is no subjunctive clause, so you should just stick with the past tense conjugation.